kerneltime commented on PR #3604: URL: https://github.com/apache/ozone/pull/3604#issuecomment-1188715854
> > Why not just log it in the units used for tracking the data (i.e. Bytes). > > It's an attempt to make the logs more readable. It's easier to read GBs, but of course bytes is more accurate. I would keep it in bytes and simplify the code. We can create a dashboard off metrics which does the conversion correctly, logs are used by developers who would want accuracy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
