kerneltime commented on PR #3604: URL: https://github.com/apache/ozone/pull/3604#issuecomment-1189842830
> > I would keep it in bytes and simplify the code. We can create a dashboard off metrics which does the conversion correctly, logs are used by developers who would want accuracy. > > Makes sense. @mukul1987 suggested logging something like this: > > ``` > Iteration Summary- > Number of datanodes involved: 4 > Size moved: 1GB (1073741824 Bytes) > Number of container moves completed: 5 > ``` > > How does this look @kerneltime? > > I would keep it in bytes and simplify the code. We can create a dashboard off metrics which does the conversion correctly, logs are used by developers who would want accuracy. > > Makes sense. @mukul1987 suggested logging something like this: > > ``` > Iteration Summary- > Number of datanodes involved: 4 > Size moved: 1GB (1073741824 Bytes) > Number of container moves completed: 5 > ``` > > How does this look @kerneltime? Ideally if you want to improve readability you need to be able to map the bytes to the right unit and print it (kb, mb, gb, tb..) This should be ok for now, unless hadoop ecosystem has a package that will to the string conversion with appropriate units for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
