Xushaohong commented on code in PR #3615:
URL: https://github.com/apache/ozone/pull/3615#discussion_r928600674
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java:
##########
@@ -181,6 +181,31 @@ public void incrementCount(List<Long> txIDs)
}
}
+ /**
+ * {@inheritDoc}
+ *
+ * @throws IOException
+ */
+ @Override
+ public int resetCount(List<Long> txIDs) throws IOException {
+ List<Long> failedTransactions = getFailedTransactions().stream()
+ .map(DeletedBlocksTransaction::getTxID).collect(Collectors.toList());
+ if (txIDs != null && !txIDs.isEmpty()) {
+ failedTransactions = failedTransactions.stream().filter(txIDs::contains)
+ .collect(Collectors.toList());
+ }
+ lock.lock();
+ try {
+ return deletedBlockLogStateManager.resetRetryCountOfTransactionInDB(
+ new ArrayList<>(failedTransactions));
+ } catch (TimeoutException | IOException ex) {
+ LOG.error("Cannot reset block deletion transactions {}",
+ failedTransactions, ex);
+ return 0;
Review Comment:
I referred to the line in BlockManagerImpl:259, both exceptions could be
treated as the same, and the maintainer shall find the stack through the log to
recognize the root cause. If it is still not a good idea, pls comment this
again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
