kaijchen commented on code in PR #3644:
URL: https://github.com/apache/ozone/pull/3644#discussion_r936173144
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/statemachine/background/BlockDeletingService.java:
##########
@@ -198,8 +198,15 @@ private boolean isDeletionAllowed(ContainerData
containerData,
if (ozoneContainer.getWriteChannel() instanceof XceiverServerRatis) {
XceiverServerRatis ratisServer =
(XceiverServerRatis) ozoneContainer.getWriteChannel();
- PipelineID pipelineID = PipelineID
- .valueOf(UUID.fromString(containerData.getOriginPipelineId()));
+ PipelineID pipelineID;
Review Comment:
This change only checks empty or null pipeline id, which is sufficient for
the EC case.
However, if there is a malformed container whose pipeline id is some random
non-empty string,
should we be able to delete blocks in it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
