kaijchen commented on code in PR #3644:
URL: https://github.com/apache/ozone/pull/3644#discussion_r936208488
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/statemachine/background/BlockDeletingService.java:
##########
@@ -194,13 +194,17 @@ private boolean isDeletionAllowed(ContainerData
containerData,
return false;
} else if (!containerData.isClosed()) {
return false;
+ } else if (containerData.getOriginPipelineId() == null
Review Comment:
> what if a ratis container does not have a originPipelineID exceptionally?
is it a good behavior to just return true directlly?
If a ratis container does not have a originPipelineID, how do we get the
`minReplicatedIndex` then?
> we should not differentiate containers by the write channel , we should
differentiate them by container type.
I agree with this. But it should be done in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
