errose28 commented on PR #3683: URL: https://github.com/apache/ozone/pull/3683#issuecomment-1217017760
Right, I believe the reason there is no removal for deleted containers from being processed for block deletes is that a container cannot be deleted until all blocks from all its replicas are deleted. This should imply that the deleted block log has no more entries for that container. 1. `DeletedBlockLogImpl#commitTransactions` checks that all replicas have processed a block deletion for a container before removing the entry. 2. `LegacyReplicationManager#deleteContainerReplicas` checks that all replicas have deleted all blocks. Since the container cannot be deleted until all blocks have been deleted, the deleted block log/table should not have any entries for the container by the time it is deleted. Do you see a case where this could fail and there are lingering delete block entries for a container which has already been deleted? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
