swamirishi commented on code in PR #3683:
URL: https://github.com/apache/ozone/pull/3683#discussion_r978996752
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/block/TestDeletedBlockLog.java:
##########
@@ -527,6 +533,22 @@ public void testDeletedBlockTransactions()
Assertions.assertEquals(2, blocks.size());
}
+ @Test
+ public void testDeletedBlockTransactionsOfDeletedContainer()
+ throws IOException, TimeoutException {
+ int txNum = 10;
+ List<DeletedBlocksTransaction> blocks;
+
+ // Creates {TXNum} TX in the log.
+ Map<Long, List<Long>> deletedBlocks = generateData(txNum,
Review Comment:
Containers are deleted only if block count is zero. In my opinion you could
also have an integration testcase with underreplicated containers & going ahead
deleting these blocks. This particular issue can happen then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
