DaveTeng0 commented on code in PR #3672:
URL: https://github.com/apache/ozone/pull/3672#discussion_r950476620
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -267,7 +267,6 @@ message AddScmResponseProto {
enum ReplicationType {
RATIS = 1;
STAND_ALONE = 2;
- CHAINED = 3;
Review Comment:
> Thanks @DaveTeng0 for working on this.
>
> I'm not sure why `CHAINED` replication type was added in the first place.
But I don't think we should remove it as a breaking change.
>
> If we want to hide it in CLI help, we can define a separate enum for the
replication types exposed to users. See `BucketLayout` vs.
`AllowedBucketLayouts` enums.
>
> We might also consider hiding `STAND_ALONE`?
Make sense! Sure let me create a new enum for the allowed replication types!
(ok will remove STAND_ALONE from the new enum as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
