adoroszlai commented on code in PR #3672:
URL: https://github.com/apache/ozone/pull/3672#discussion_r951417016
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/ReplicationConfig.java:
##########
@@ -177,20 +177,6 @@ static ReplicationConfig
parseWithoutFallback(ReplicationType type,
ReplicationConfig replicationConfig;
switch (type) {
case RATIS:
- case STAND_ALONE:
- ReplicationFactor factor;
- try {
- factor = ReplicationFactor.valueOf(Integer.parseInt(replication));
- } catch (NumberFormatException ex) {
- try {
- factor = ReplicationFactor.valueOf(replication);
- } catch (IllegalArgumentException e) {
- throw new IllegalArgumentException(replication +
- " is not supported for " + type + " replication type", e);
- }
- }
- replicationConfig = fromTypeAndFactor(type, factor);
- break;
Review Comment:
No, I think we should keep it here. But the code in this `case` should not
be removed in either case, as it also applicable for `RATIS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
