siddhantsangwan commented on code in PR #3723:
URL: https://github.com/apache/ozone/pull/3723#discussion_r957067384
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/node/TestDecommissionAndMaintenance.java:
##########
@@ -385,8 +426,32 @@ public void
testContainerIsReplicatedWhenAllNodesGotoMaintenance()
for (DatanodeDetails dn : forMaintenance) {
waitForDnToReachOpState(dn, IN_SERVICE);
}
-
waitForContainerReplicas(container, 3);
+
+ // Now write some EC data and put two nodes into maintenance. This should
+ // result in at least 1 extra replica getting created.
+ generateData(20, "eckey", ecRepConfig);
+ final ContainerInfo ecContainer =
+ waitForAndReturnContainer(ecRepConfig, 5);
+ List<DatanodeDetails> ecMaintenance = replicas.stream()
+ .map(ContainerReplica::getDatanodeDetails)
+ .limit(2)
+ .collect(Collectors.toList());
+ scmClient.startMaintenanceNodes(ecMaintenance.stream()
+ .map(this::getDNHostAndPort)
+ .collect(Collectors.toList()), 0);
+ for (DatanodeDetails dn : ecMaintenance) {
+ waitForDnToReachPersistedOpState(dn, IN_MAINTENANCE);
+ }
+ assertTrue(cm.getContainerReplicas(ecContainer.containerID()).size() >= 6);
+ scmClient.recommissionNodes(forMaintenance.stream()
+ .map(this::getDNHostAndPort)
+ .collect(Collectors.toList()));
+ // Ensure the 2 DNs go to maintenance
Review Comment:
"maintenance" should be "in-service" in the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
