umamaheswararao commented on code in PR #3723:
URL: https://github.com/apache/ozone/pull/3723#discussion_r959617540
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -686,6 +688,38 @@ public void setMaintenanceReplicaMinimum(int replicaCount)
{
this.maintenanceReplicaMinimum = replicaCount;
}
+ /**
+ * Defines how many redundant replicas of a container must be online for a
+ * node to enter maintenance. Currently, only used for EC containers. We
+ * need to consider removing the "maintenance.replica.minimum" setting
+ * and having both Ratis and EC use this new one.
+ */
+ @Config(key = "maintenance.remaining.redundancy",
+ type = ConfigType.INT,
+ defaultValue = "1",
+ tags = {SCM, OZONE},
+ description = "The number of redundant containers in a group which" +
+ " must be available for a node to enter maintenance. If putting" +
+ " a node into maintenance reduces the redundancy below this value"
+
+ " , the node will remain in the entering maintenance state until" +
+ " a new replica is created. For Ratis containers, the default" +
+ " value of 1 ensures at least two replicas are online, meaning 1" +
+ " more can be lost without data becoming unavailable. For any EC" +
+ " container it will have at least dataNum + 1 online, allowing" +
+ " the loss of 1 more replica before data becomes unavailable." +
Review Comment:
But for EC, users should aware that, online reconstruction happens, and
hence they may see impact in performance. For no performance impact, the very
positive case would be [replicaIndex until datanum + 1]. Things will be
complicated. I think we must make users aware of the impact when putting nodes
in maintenance.
No plans to add this config in ozone-defaults.xml ?
Do you know this descriptions will be available as part of admin guides or
so? I am not sure that happens, then they will be just dev descriptions.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -686,6 +688,38 @@ public void setMaintenanceReplicaMinimum(int replicaCount)
{
this.maintenanceReplicaMinimum = replicaCount;
}
+ /**
+ * Defines how many redundant replicas of a container must be online for a
+ * node to enter maintenance. Currently, only used for EC containers. We
+ * need to consider removing the "maintenance.replica.minimum" setting
+ * and having both Ratis and EC use this new one.
+ */
+ @Config(key = "maintenance.remaining.redundancy",
+ type = ConfigType.INT,
+ defaultValue = "1",
+ tags = {SCM, OZONE},
+ description = "The number of redundant containers in a group which" +
+ " must be available for a node to enter maintenance. If putting" +
+ " a node into maintenance reduces the redundancy below this value"
+
Review Comment:
Nit: entering maintenance -> ENTERING_MAINTENANCE
Just suggesting to use exact state than words.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -686,6 +688,38 @@ public void setMaintenanceReplicaMinimum(int replicaCount)
{
this.maintenanceReplicaMinimum = replicaCount;
}
+ /**
+ * Defines how many redundant replicas of a container must be online for a
+ * node to enter maintenance. Currently, only used for EC containers. We
+ * need to consider removing the "maintenance.replica.minimum" setting
Review Comment:
I would suggest to file a JIRA and give that JIRA ref here for removal of
maintenanc.replica.minimum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
