nandakumar131 commented on code in PR #3753:
URL: https://github.com/apache/ozone/pull/3753#discussion_r971620685
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/pipelines/pipelines.tsx:
##########
@@ -247,7 +247,7 @@ export class Pipelines extends
React.Component<Record<string, object>, IPipeline
}, [])}
loading={activeLoading} pagination={paginationConfig}
rowKey='pipelineId'/>
</TabPane>
- <TabPane key='2' tab='Inactive'/>
+
Review Comment:
@smengcl, thanks for taking a look at this change. The TODO referred in
[ReconPipelineManager.java](https://github.com/apache/ozone/blob/a02c6df497b2a636c7a81c26e53f39daa7958841/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconPipelineManager.java#L132-L134)
talks about tracking pipelines which are closed and deleted in SCM. In Recon,
it is possible to maintain the history of pipelines and show it to the user.
This functionality can be easily added. But calling it an "Inactive" pipeline
will bring in confusion as we have something called Dormant/Inactive state for
a pipeline in SCM, which was introduced for debugging purposes. We also have
_activate_ and _deactivate_ pipeline commands in SCM.
Ref: [HDDS-1810](https://issues.apache.org/jira/browse/HDDS-1810)
To have clarity, we can have a different tab name (something other than
Inactive) in Recon to show the Pipeline history (deleted pipelines). We can do
this when we start working on that functionality.
Since "activate" and "deactivate" (Dormant State) was introduced for
testing/debugging purposes, it is better to hide them from the end user in the
Recon UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
