siddhantsangwan commented on PR #3751: URL: https://github.com/apache/ozone/pull/3751#issuecomment-1247730996
Overall, I think it's better to count failed moves in the `whenComplete((result, ex)` stage of completable future in the `moveContainer` method. That way, we can count all the failures at one place. `checkIterationMoveResults` can be used for updating aggregate metrics (across all iterations). @sumitagrawl What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
