siddhantsangwan commented on PR #3751: URL: https://github.com/apache/ozone/pull/3751#issuecomment-1249362646
> I checked internet, replication.move() should return completable failure, and must not throw exception to get in whenComplete() handling, currently replication code is not written in this manner, so exception will never come. Any checked exceptions thrown by `replicationManager.move` can be counted in their respective catch blocks. Other execution exceptions can be handled in `whenComplete`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
