sumitagrawl commented on code in PR #3751:
URL: https://github.com/apache/ozone/pull/3751#discussion_r977564607
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java:
##########
@@ -529,22 +529,17 @@ private void checkIterationMoveResults() {
allFuturesResult.get(config.getMoveTimeout().toMillis(),
TimeUnit.MILLISECONDS);
} catch (InterruptedException e) {
+ long cancelCount = cancelAndCountPendingMoves();
+ metrics.incrementNumContainerMovesFailed(cancelCount);
+ LOG.warn("Container balancer is interrupted and moves are cancelled {}",
+ cancelCount);
Review Comment:
Removed the case of counting as failed. Just cancelling the moves. But as
cancel, possibly of exception caught in whenComplete(), that will be counted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
