GeorgeJahad commented on code in PR #3746:
URL: https://github.com/apache/ozone/pull/3746#discussion_r979139397
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/BucketHandler.java:
##########
@@ -183,8 +183,17 @@ public static BucketHandler getBucketHandler(
OzoneStorageContainerManager reconSCM,
OmBucketInfo bucketInfo) throws IOException {
- return new FSOBucketHandler(reconNamespaceSummaryManager,
+ if (bucketInfo.getBucketLayout()
Review Comment:
This version of getBucketHandler will throw an NPE if bucketInfo is null.
The other version just returns
[null](https://github.com/apache/ozone/blob/39c0c25c07e359a1e5f0968a2143db1dc9da3c19/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/BucketHandler.java#L210).
They should do the same thing, probably both throw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
