xBis7 commented on code in PR #3750:
URL: https://github.com/apache/ozone/pull/3750#discussion_r982131232
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/TestOMClientRequestWithUserInfo.java:
##########
@@ -95,7 +96,8 @@ public void testUserInfo() throws Exception {
String volumeName = UUID.randomUUID().toString();
OzoneManagerProtocolProtos.OMRequest omRequest =
OMRequestTestUtils.createBucketRequest(bucketName, volumeName, true,
- OzoneManagerProtocolProtos.StorageTypeProto.DISK);
+ OzoneManagerProtocolProtos.StorageTypeProto.DISK,
+ ClientVersion.DEFAULT_VERSION.toProtoValue());
Review Comment:
@errose28 All the existing tests were using `ClientVersion` 0 to execute
[this
block](https://github.com/xBis7/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java#L275-L284).
In our case we needed to test the
[else](https://github.com/xBis7/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java#L285-L298)
statement that needs to use the latest `ClientVersion` in order to execute.
For consistency and not making any changes to the existing tests, we used
`ClientVersion.DEFAULT_VERSION`. Also see this [comment
here](https://github.com/apache/ozone/pull/3750#discussion_r971350019) as
@neils-dev mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
