neils-dev commented on PR #3750: URL: https://github.com/apache/ozone/pull/3750#issuecomment-1260101679
Thanks @kerneltime for your comment. I was about to close it. On setting the default layout in the `rpcClient.` I'm not sure there is a problem with this fix. If the client specifies the layout in the `createbucket `request then there is no issue. If the client does not specify the layout, then in the `rpcClient `that is common to all clients, the default layout from the `OmConfigKeys` is used. The `rpcClient` is common for all clients and if the client does not have a specific config for the layout the default for the OM is used. This seems to match up for what the user may expect the client behavior to be. If there is _**no specific**_ config for the client to set the default layout from, then the user expects the config _ozone.default.bucket.layout_ (which is from the `OmConfigKeys`). What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
