siddhantsangwan commented on code in PR #3785: URL: https://github.com/apache/ozone/pull/3785#discussion_r982164031
########## hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/health/TestQuasiClosedContainerHandler.java: ########## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.scm.container.replication.health; + +import org.apache.hadoop.hdds.client.ECReplicationConfig; +import org.apache.hadoop.hdds.client.RatisReplicationConfig; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos; +import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.ContainerReplicaProto.State; +import org.apache.hadoop.hdds.scm.container.ContainerInfo; +import org.apache.hadoop.hdds.scm.container.ContainerReplica; +import org.apache.hadoop.hdds.scm.container.ReplicationManagerReport; +import org.apache.hadoop.hdds.scm.container.replication.ContainerCheckRequest; +import org.apache.hadoop.hdds.scm.container.replication.ReplicationManager; +import org.apache.hadoop.hdds.scm.container.replication.ReplicationTestUtil; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.mockito.Mockito; + +import java.util.Collections; +import java.util.Set; + +import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.LifeCycleState.OPEN; +import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.LifeCycleState.QUASI_CLOSED; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyBoolean; +import static org.mockito.Mockito.times; + +/** + * Tests for {@link QuasiClosedContainerHandler}. This handler is only meant + * to handle Ratis containers. + */ +public class TestQuasiClosedContainerHandler { + private ReplicationManager replicationManager; + private QuasiClosedContainerHandler quasiClosedContainerHandler; + private RatisReplicationConfig ratisReplicationConfig; + + @BeforeEach + public void setup() { + ratisReplicationConfig = RatisReplicationConfig.getInstance( + HddsProtos.ReplicationFactor.THREE); + replicationManager = Mockito.mock(ReplicationManager.class); + quasiClosedContainerHandler = + new QuasiClosedContainerHandler(replicationManager); + } + + @Test + public void testECContainerReturnsFalse() { + ContainerInfo containerInfo = ReplicationTestUtil.createContainerInfo( + new ECReplicationConfig(3, 2), 1, QUASI_CLOSED); + Set<ContainerReplica> containerReplicas = ReplicationTestUtil + .createReplicas(containerInfo.containerID(), + State.QUASI_CLOSED, 1, 2, 3); + ContainerCheckRequest request = new ContainerCheckRequest.Builder() + .setPendingOps(Collections.EMPTY_LIST) + .setReport(new ReplicationManagerReport()) + .setContainerInfo(containerInfo) + .setContainerReplicas(containerReplicas) + .build(); + + Assertions.assertFalse(quasiClosedContainerHandler.handle(request)); + Mockito.verify(replicationManager, times(0)) + .sendCloseContainerReplicaCommand(any(), any(), anyBoolean()); + } + + @Test + public void testOpenContainerReturnsFalse() { + ContainerInfo containerInfo = ReplicationTestUtil.createContainerInfo( + ratisReplicationConfig, 1, OPEN); + Set<ContainerReplica> containerReplicas = ReplicationTestUtil + .createReplicas(containerInfo.containerID(), + State.OPEN, 1, 2, 3); + ContainerCheckRequest request = new ContainerCheckRequest.Builder() + .setPendingOps(Collections.EMPTY_LIST) + .setReport(new ReplicationManagerReport()) + .setContainerInfo(containerInfo) + .setContainerReplicas(containerReplicas) + .build(); + + Assertions.assertFalse(quasiClosedContainerHandler.handle(request)); + Mockito.verify(replicationManager, times(0)) + .sendCloseContainerReplicaCommand(any(), any(), anyBoolean()); + } + + /** + * When a container is QUASI_CLOSED, and it has greater than 50% of its + * replicas in QUASI_CLOSED state with unique origin node id, + * the handler should send force close commands to the replica(s) with + * highest BCSID. + */ + @Test + public void testQuasiClosedWithQuorumReturnsTrue() { + ContainerInfo containerInfo = ReplicationTestUtil.createContainerInfo( + ratisReplicationConfig, 1, QUASI_CLOSED); + Set<ContainerReplica> containerReplicas = ReplicationTestUtil + .createReplicas(containerInfo.containerID(), + State.QUASI_CLOSED, 1, 2); + ContainerReplica openReplica = ReplicationTestUtil.createContainerReplica( + containerInfo.containerID(), 3, + HddsProtos.NodeOperationalState.IN_SERVICE, State.OPEN); + containerReplicas.add(openReplica); + ContainerCheckRequest request = new ContainerCheckRequest.Builder() + .setPendingOps(Collections.EMPTY_LIST) + .setReport(new ReplicationManagerReport()) + .setContainerInfo(containerInfo) + .setContainerReplicas(containerReplicas) + .build(); + + Assertions.assertTrue(quasiClosedContainerHandler.handle(request)); + Mockito.verify(replicationManager, times(2)) + .sendCloseContainerReplicaCommand(any(), any(), anyBoolean()); + } + + /** + * The replicas are QUASI_CLOSED, but all of them have the same origin node + * id. Since a quorum with unique origin node ids (greater than 50% of + * replicas) is not formed, the handler should return false. + */ + @Test + public void testHealthyQuasiClosedContainerReturnsFalse() { + ContainerInfo containerInfo = ReplicationTestUtil.createContainerInfo( + ratisReplicationConfig, 1, QUASI_CLOSED); + Set<ContainerReplica> containerReplicas = ReplicationTestUtil + .createReplicasWithSameOrigin(containerInfo.containerID(), + State.QUASI_CLOSED, 1, 2, 3); Review Comment: Got it. Will also need to change this in the Ratis related tests for other handlers. I'll open another PR for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
