siddhantsangwan commented on code in PR #3785: URL: https://github.com/apache/ozone/pull/3785#discussion_r982365844
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/QuasiClosedContainerHandler.java: ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.scm.container.replication.health; + +import org.apache.hadoop.hdds.protocol.proto.HddsProtos; +import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.ContainerReplicaProto.State; +import org.apache.hadoop.hdds.scm.container.ContainerInfo; +import org.apache.hadoop.hdds.scm.container.ContainerReplica; +import org.apache.hadoop.hdds.scm.container.ReplicationManagerReport; +import org.apache.hadoop.hdds.scm.container.replication.ContainerCheckRequest; +import org.apache.hadoop.hdds.scm.container.replication.ReplicationManager; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.List; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * Class for handling containers that are in QUASI_CLOSED state. This will + * send commands to Datanodes to force close these containers if they satisfy + * the requirements to be force closed. + */ +public class QuasiClosedContainerHandler extends AbstractCheck { + public static final Logger LOG = + LoggerFactory.getLogger(QuasiClosedContainerHandler.class); + + private final ReplicationManager replicationManager; + + public QuasiClosedContainerHandler(ReplicationManager replicationManager) { + this.replicationManager = replicationManager; + } + + /** + * If possible, force closes the Ratis container in QUASI_CLOSED state. + * Replicas with the highest Sequence ID are selected to be closed. + * @param request ContainerCheckRequest object representing the container + * @return true if close commands were sent, otherwise false + */ + @Override + public boolean handle(ContainerCheckRequest request) { + ContainerInfo containerInfo = request.getContainerInfo(); + if (containerInfo.getReplicationType() == HddsProtos.ReplicationType.EC) { + return false; + } + + if (containerInfo.getState() != HddsProtos.LifeCycleState.QUASI_CLOSED) { + return false; + } + + Set<ContainerReplica> replicas = request.getContainerReplicas(); + if (canForceCloseContainer(containerInfo, replicas)) { + forceCloseContainer(containerInfo, replicas); + return true; + } else { + request.getReport().incrementAndSample( + ReplicationManagerReport.HealthState.QUASI_CLOSED_STUCK, + containerInfo.containerID()); + } + return false; + } + + /** + * Returns true if more than 50% of the container replicas with unique + * originNodeId are in QUASI_CLOSED state. + * + * @param container Container to check + * @param replicas Set of ContainerReplicas + * @return true if we can force close the container, false otherwise + */ + private boolean canForceCloseContainer(final ContainerInfo container, + final Set<ContainerReplica> replicas) { + final int replicationFactor = + container.getReplicationConfig().getRequiredNodes(); + final long uniqueQuasiClosedReplicaCount = replicas.stream() + .filter(r -> r.getState() == State.QUASI_CLOSED) + .map(ContainerReplica::getOriginDatanodeId) + .distinct() + .count(); + return uniqueQuasiClosedReplicaCount > (replicationFactor / 2); + } + + /** + * Force close the container replica(s) with the highest Sequence ID. + * + * <p> + * Note: We should force close the container only if >50% (quorum) + * of replicas with unique originNodeId are in QUASI_CLOSED state. + * </p> + * + * @param container ContainerInfo + * @param replicas Set of ContainerReplicas + */ + private void forceCloseContainer(final ContainerInfo container, + final Set<ContainerReplica> replicas) { + final List<ContainerReplica> quasiClosedReplicas = replicas.stream() + .filter(r -> r.getState() == State.QUASI_CLOSED) + .collect(Collectors.toList()); + + final Long sequenceId = quasiClosedReplicas.stream() + .map(ContainerReplica::getSequenceId) + .max(Long::compare) + .orElse(-1L); + + LOG.info("Force closing container {} with BCSID {}, which is in " + + "QUASI_CLOSED state.", container.containerID(), sequenceId); + + quasiClosedReplicas.stream() + .filter(r -> sequenceId != -1L) + .filter(replica -> replica.getSequenceId().equals(sequenceId)) Review Comment: Added `testReplicasWithHighestBCSIDAreClosed` in the latest commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
