sodonnel commented on code in PR #3802:
URL: https://github.com/apache/ozone/pull/3802#discussion_r992103112
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ContainerHealthResult.java:
##########
@@ -106,6 +106,9 @@ public static class UnHealthyResult extends
ContainerHealthResult {
private final int remainingRedundancy;
private final boolean dueToDecommission;
private final boolean sufficientlyReplicatedAfterPending;
+ private boolean dueToMisReplication = false;
+ private boolean isMisReplicated = false;
+ private boolean isMisReplicatedAfterPending = false;
Review Comment:
I don't want to change the existing constructor, as then we need to change
it everywhere it is used. Adding a new constructor starts a bad pattern where
each new parameter needs a new constructor, and what we really need is a
builder.
At the moment I think these 3 parameters have good defaults for the common
case and then using the settings when needed is a good compromise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
