siddhantsangwan commented on code in PR #3802: URL: https://github.com/apache/ozone/pull/3802#discussion_r998096952
########## hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/health/TestRatisReplicationCheckHandler.java: ########## @@ -0,0 +1,560 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p/> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p/> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.hadoop.hdds.scm.container.replication.health; + +import org.apache.commons.lang3.tuple.Pair; +import org.apache.hadoop.hdds.client.ECReplicationConfig; +import org.apache.hadoop.hdds.client.RatisReplicationConfig; +import org.apache.hadoop.hdds.client.ReplicationConfig; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.protocol.MockDatanodeDetails; +import org.apache.hadoop.hdds.scm.PlacementPolicy; +import org.apache.hadoop.hdds.scm.container.ContainerInfo; +import org.apache.hadoop.hdds.scm.container.ContainerReplica; +import org.apache.hadoop.hdds.scm.container.ReplicationManagerReport; +import org.apache.hadoop.hdds.scm.container.placement.algorithms.ContainerPlacementStatusDefault; +import org.apache.hadoop.hdds.scm.container.replication.ContainerCheckRequest; +import org.apache.hadoop.hdds.scm.container.replication.ContainerHealthResult; +import org.apache.hadoop.hdds.scm.container.replication.ContainerHealthResult.HealthState; +import org.apache.hadoop.hdds.scm.container.replication.ContainerHealthResult.OverReplicatedHealthResult; +import org.apache.hadoop.hdds.scm.container.replication.ContainerHealthResult.UnderReplicatedHealthResult; +import org.apache.hadoop.hdds.scm.container.replication.ContainerReplicaOp; +import org.apache.hadoop.hdds.scm.container.replication.ReplicationQueue; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; +import org.mockito.Mockito; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Set; + +import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.NodeOperationalState.DECOMMISSIONED; +import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.NodeOperationalState.DECOMMISSIONING; +import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.NodeOperationalState.IN_MAINTENANCE; +import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.NodeOperationalState.IN_SERVICE; +import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationFactor.THREE; +import static org.apache.hadoop.hdds.scm.container.replication.ContainerReplicaOp.PendingOpType.ADD; +import static org.apache.hadoop.hdds.scm.container.replication.ContainerReplicaOp.PendingOpType.DELETE; +import static org.apache.hadoop.hdds.scm.container.replication.ReplicationTestUtil.createContainerInfo; +import static org.apache.hadoop.hdds.scm.container.replication.ReplicationTestUtil.createReplicas; + +/** + * Tests for the RatisReplicationCheckHandler class. + */ +public class TestRatisReplicationCheckHandler { + + private RatisReplicationCheckHandler healthCheck; + private ReplicationConfig repConfig; + private PlacementPolicy containerPlacementPolicy; + private ReplicationQueue repQueue; + private ContainerCheckRequest.Builder requestBuilder; + private ReplicationManagerReport report; + private int maintenanceRedundancy = 2; + + @Before + public void setup() throws IOException { + containerPlacementPolicy = Mockito.mock(PlacementPolicy.class); + Mockito.when(containerPlacementPolicy.validateContainerPlacement( + Mockito.any(), + Mockito.anyInt() + )).thenAnswer(invocation -> + new ContainerPlacementStatusDefault(2, 2, 3)); + healthCheck = new RatisReplicationCheckHandler(containerPlacementPolicy); + repConfig = RatisReplicationConfig.getInstance(THREE); + repQueue = new ReplicationQueue(); + report = new ReplicationManagerReport(); + requestBuilder = new ContainerCheckRequest.Builder() + .setReplicationQueue(repQueue) + .setMaintenanceRedundancy(maintenanceRedundancy) + .setPendingOps(Collections.emptyList()) + .setReport(report); + } + + @Test + public void testReturnFalseForNonRatis() { + ContainerInfo container = + createContainerInfo(new ECReplicationConfig(3, 2)); + Set<ContainerReplica> replicas = + createReplicas(container.containerID(), 1, 2, 3, 4); + + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container); + Assert.assertFalse(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + } + + @Test + public void testHealthyContainerIsHealthy() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas + = createReplicas(container.containerID(), 0, 0, 0); + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container); + ContainerHealthResult result = + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.HEALTHY, result.getHealthState()); + + Assert.assertFalse(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + } + + @Test + public void testUnderReplicatedContainerIsUnderReplicated() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas + = createReplicas(container.containerID(), 0, 0); + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(1, result.getRemainingRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + Assert.assertFalse(result.underReplicatedDueToDecommission()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(1, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + } + + @Test + public void testUnderReplicatedContainerDueToPendingDelete() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas + = createReplicas(container.containerID(), 0, 0, 0); + List<ContainerReplicaOp> pending = new ArrayList<>(); + pending.add(ContainerReplicaOp.create( + DELETE, MockDatanodeDetails.randomDatanodeDetails(), 0)); + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container) + .setPendingOps(pending); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(1, result.getRemainingRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + Assert.assertFalse(result.underReplicatedDueToDecommission()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(1, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + } + + @Test + public void testUnderReplicatedContainerFixedWithPending() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas + = createReplicas(container.containerID(), 0, 0); + List<ContainerReplicaOp> pending = new ArrayList<>(); + pending.add(ContainerReplicaOp.create( + ADD, MockDatanodeDetails.randomDatanodeDetails(), 0)); + requestBuilder.setContainerReplicas(replicas) + .setPendingOps(pending) + .setContainerInfo(container); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(1, result.getRemainingRedundancy()); + Assert.assertTrue(result.isSufficientlyReplicatedAfterPending()); + Assert.assertFalse(result.underReplicatedDueToDecommission()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + // Fixed with pending, so nothing added to the queue + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + // Still under replicated until the pending complete + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + } + + @Test + public void testUnderReplicatedDueToDecommission() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = createReplicas(container.containerID(), + Pair.of(IN_SERVICE, 0), Pair.of(DECOMMISSIONING, 0), + Pair.of(DECOMMISSIONED, 0)); + + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(2, result.getRemainingRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + Assert.assertTrue(result.underReplicatedDueToDecommission()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(1, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + } + + @Test + public void testUnderReplicatedDueToDecommissionFixedWithPending() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = createReplicas(container.containerID(), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0), + Pair.of(DECOMMISSIONED, 0)); + List<ContainerReplicaOp> pending = new ArrayList<>(); + pending.add(ContainerReplicaOp.create( + ADD, MockDatanodeDetails.randomDatanodeDetails(), 0)); + + requestBuilder.setContainerReplicas(replicas) + .setPendingOps(pending) + .setContainerInfo(container); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(2, result.getRemainingRedundancy()); + Assert.assertTrue(result.isSufficientlyReplicatedAfterPending()); + Assert.assertTrue(result.underReplicatedDueToDecommission()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + // Nothing queued as inflight replicas will fix it. + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + // Still under replicated in the report until pending complete + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + } + + @Test + public void testUnderReplicatedDueToDecommissionAndMissing() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = createReplicas(container.containerID(), + Pair.of(IN_SERVICE, 0), Pair.of(DECOMMISSIONED, 0)); + List<ContainerReplicaOp> pending = new ArrayList<>(); + pending.add(ContainerReplicaOp.create( + ADD, MockDatanodeDetails.randomDatanodeDetails(), 0)); + + requestBuilder.setContainerReplicas(replicas) + .setPendingOps(pending) + .setContainerInfo(container); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(1, result.getRemainingRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + Assert.assertFalse(result.underReplicatedDueToDecommission()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(1, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + } + + @Test + public void testUnderReplicatedAndUnrecoverable() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = Collections.EMPTY_SET; + + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(0, result.getRemainingRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + Assert.assertFalse(result.underReplicatedDueToDecommission()); + Assert.assertTrue(result.isUnrecoverable()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + // Unrecoverable, so not added to the queue. + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.MISSING)); + } + + @Test + public void testOverReplicatedContainer() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = createReplicas(container.containerID(), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0), + Pair.of(IN_SERVICE, 0), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0)); + + List<ContainerReplicaOp> pending = new ArrayList<>(); + pending.add(ContainerReplicaOp.create( + DELETE, MockDatanodeDetails.randomDatanodeDetails(), 0)); + pending.add(ContainerReplicaOp.create( + DELETE, MockDatanodeDetails.randomDatanodeDetails(), 0)); + + requestBuilder.setContainerReplicas(replicas) + .setPendingOps(pending) + .setContainerInfo(container); + OverReplicatedHealthResult result = (OverReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.OVER_REPLICATED, result.getHealthState()); + Assert.assertEquals(4, result.getExcessRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(1, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.OVER_REPLICATED)); + } + + @Test + public void testOverReplicatedContainerFixedByPending() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = createReplicas(container.containerID(), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0)); + + List<ContainerReplicaOp> pending = new ArrayList<>(); + pending.add(ContainerReplicaOp.create( + DELETE, MockDatanodeDetails.randomDatanodeDetails(), 0)); + + requestBuilder.setContainerReplicas(replicas) + .setPendingOps(pending) + .setContainerInfo(container); + OverReplicatedHealthResult result = (OverReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.OVER_REPLICATED, result.getHealthState()); + Assert.assertEquals(1, result.getExcessRedundancy()); + Assert.assertTrue(result.isSufficientlyReplicatedAfterPending()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + // Fixed by pending so nothing queued. + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + // Still over replicated, so the report should contain it + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.OVER_REPLICATED)); + } + + @Test + public void testOverReplicatedContainerWithMaintenance() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = createReplicas(container.containerID(), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0), + Pair.of(IN_MAINTENANCE, 0), Pair.of(DECOMMISSIONED, 0)); + + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container); + OverReplicatedHealthResult result = (OverReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.OVER_REPLICATED, result.getHealthState()); + Assert.assertEquals(1, result.getExcessRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(1, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.OVER_REPLICATED)); + } + + @Test + public void testOverReplicatedContainerDueToMaintenance() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = createReplicas(container.containerID(), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0), + Pair.of(IN_SERVICE, 0), Pair.of(IN_MAINTENANCE, 0), + Pair.of(IN_MAINTENANCE, 2)); Review Comment: The replica index should be 0 instead of 2 I think. `(IN_MAINTENANCE, 0)` ########## hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/health/TestRatisReplicationCheckHandler.java: ########## @@ -0,0 +1,560 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p/> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p/> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.hadoop.hdds.scm.container.replication.health; + +import org.apache.commons.lang3.tuple.Pair; +import org.apache.hadoop.hdds.client.ECReplicationConfig; +import org.apache.hadoop.hdds.client.RatisReplicationConfig; +import org.apache.hadoop.hdds.client.ReplicationConfig; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.protocol.MockDatanodeDetails; +import org.apache.hadoop.hdds.scm.PlacementPolicy; +import org.apache.hadoop.hdds.scm.container.ContainerInfo; +import org.apache.hadoop.hdds.scm.container.ContainerReplica; +import org.apache.hadoop.hdds.scm.container.ReplicationManagerReport; +import org.apache.hadoop.hdds.scm.container.placement.algorithms.ContainerPlacementStatusDefault; +import org.apache.hadoop.hdds.scm.container.replication.ContainerCheckRequest; +import org.apache.hadoop.hdds.scm.container.replication.ContainerHealthResult; +import org.apache.hadoop.hdds.scm.container.replication.ContainerHealthResult.HealthState; +import org.apache.hadoop.hdds.scm.container.replication.ContainerHealthResult.OverReplicatedHealthResult; +import org.apache.hadoop.hdds.scm.container.replication.ContainerHealthResult.UnderReplicatedHealthResult; +import org.apache.hadoop.hdds.scm.container.replication.ContainerReplicaOp; +import org.apache.hadoop.hdds.scm.container.replication.ReplicationQueue; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; +import org.mockito.Mockito; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Set; + +import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.NodeOperationalState.DECOMMISSIONED; +import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.NodeOperationalState.DECOMMISSIONING; +import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.NodeOperationalState.IN_MAINTENANCE; +import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.NodeOperationalState.IN_SERVICE; +import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationFactor.THREE; +import static org.apache.hadoop.hdds.scm.container.replication.ContainerReplicaOp.PendingOpType.ADD; +import static org.apache.hadoop.hdds.scm.container.replication.ContainerReplicaOp.PendingOpType.DELETE; +import static org.apache.hadoop.hdds.scm.container.replication.ReplicationTestUtil.createContainerInfo; +import static org.apache.hadoop.hdds.scm.container.replication.ReplicationTestUtil.createReplicas; + +/** + * Tests for the RatisReplicationCheckHandler class. + */ +public class TestRatisReplicationCheckHandler { + + private RatisReplicationCheckHandler healthCheck; + private ReplicationConfig repConfig; + private PlacementPolicy containerPlacementPolicy; + private ReplicationQueue repQueue; + private ContainerCheckRequest.Builder requestBuilder; + private ReplicationManagerReport report; + private int maintenanceRedundancy = 2; + + @Before + public void setup() throws IOException { + containerPlacementPolicy = Mockito.mock(PlacementPolicy.class); + Mockito.when(containerPlacementPolicy.validateContainerPlacement( + Mockito.any(), + Mockito.anyInt() + )).thenAnswer(invocation -> + new ContainerPlacementStatusDefault(2, 2, 3)); + healthCheck = new RatisReplicationCheckHandler(containerPlacementPolicy); + repConfig = RatisReplicationConfig.getInstance(THREE); + repQueue = new ReplicationQueue(); + report = new ReplicationManagerReport(); + requestBuilder = new ContainerCheckRequest.Builder() + .setReplicationQueue(repQueue) + .setMaintenanceRedundancy(maintenanceRedundancy) + .setPendingOps(Collections.emptyList()) + .setReport(report); + } + + @Test + public void testReturnFalseForNonRatis() { + ContainerInfo container = + createContainerInfo(new ECReplicationConfig(3, 2)); + Set<ContainerReplica> replicas = + createReplicas(container.containerID(), 1, 2, 3, 4); + + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container); + Assert.assertFalse(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + } + + @Test + public void testHealthyContainerIsHealthy() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas + = createReplicas(container.containerID(), 0, 0, 0); + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container); + ContainerHealthResult result = + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.HEALTHY, result.getHealthState()); + + Assert.assertFalse(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + } + + @Test + public void testUnderReplicatedContainerIsUnderReplicated() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas + = createReplicas(container.containerID(), 0, 0); + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(1, result.getRemainingRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + Assert.assertFalse(result.underReplicatedDueToDecommission()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(1, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + } + + @Test + public void testUnderReplicatedContainerDueToPendingDelete() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas + = createReplicas(container.containerID(), 0, 0, 0); + List<ContainerReplicaOp> pending = new ArrayList<>(); + pending.add(ContainerReplicaOp.create( + DELETE, MockDatanodeDetails.randomDatanodeDetails(), 0)); + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container) + .setPendingOps(pending); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(1, result.getRemainingRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + Assert.assertFalse(result.underReplicatedDueToDecommission()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(1, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + } + + @Test + public void testUnderReplicatedContainerFixedWithPending() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas + = createReplicas(container.containerID(), 0, 0); + List<ContainerReplicaOp> pending = new ArrayList<>(); + pending.add(ContainerReplicaOp.create( + ADD, MockDatanodeDetails.randomDatanodeDetails(), 0)); + requestBuilder.setContainerReplicas(replicas) + .setPendingOps(pending) + .setContainerInfo(container); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(1, result.getRemainingRedundancy()); + Assert.assertTrue(result.isSufficientlyReplicatedAfterPending()); + Assert.assertFalse(result.underReplicatedDueToDecommission()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + // Fixed with pending, so nothing added to the queue + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + // Still under replicated until the pending complete + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + } + + @Test + public void testUnderReplicatedDueToDecommission() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = createReplicas(container.containerID(), + Pair.of(IN_SERVICE, 0), Pair.of(DECOMMISSIONING, 0), + Pair.of(DECOMMISSIONED, 0)); + + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(2, result.getRemainingRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + Assert.assertTrue(result.underReplicatedDueToDecommission()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(1, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + } + + @Test + public void testUnderReplicatedDueToDecommissionFixedWithPending() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = createReplicas(container.containerID(), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0), + Pair.of(DECOMMISSIONED, 0)); + List<ContainerReplicaOp> pending = new ArrayList<>(); + pending.add(ContainerReplicaOp.create( + ADD, MockDatanodeDetails.randomDatanodeDetails(), 0)); + + requestBuilder.setContainerReplicas(replicas) + .setPendingOps(pending) + .setContainerInfo(container); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(2, result.getRemainingRedundancy()); + Assert.assertTrue(result.isSufficientlyReplicatedAfterPending()); + Assert.assertTrue(result.underReplicatedDueToDecommission()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + // Nothing queued as inflight replicas will fix it. + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + // Still under replicated in the report until pending complete + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + } + + @Test + public void testUnderReplicatedDueToDecommissionAndMissing() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = createReplicas(container.containerID(), + Pair.of(IN_SERVICE, 0), Pair.of(DECOMMISSIONED, 0)); + List<ContainerReplicaOp> pending = new ArrayList<>(); + pending.add(ContainerReplicaOp.create( + ADD, MockDatanodeDetails.randomDatanodeDetails(), 0)); + + requestBuilder.setContainerReplicas(replicas) + .setPendingOps(pending) + .setContainerInfo(container); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(1, result.getRemainingRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + Assert.assertFalse(result.underReplicatedDueToDecommission()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(1, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + } + + @Test + public void testUnderReplicatedAndUnrecoverable() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = Collections.EMPTY_SET; + + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container); + UnderReplicatedHealthResult result = (UnderReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState()); + Assert.assertEquals(0, result.getRemainingRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + Assert.assertFalse(result.underReplicatedDueToDecommission()); + Assert.assertTrue(result.isUnrecoverable()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + // Unrecoverable, so not added to the queue. + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.UNDER_REPLICATED)); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.MISSING)); + } + + @Test + public void testOverReplicatedContainer() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = createReplicas(container.containerID(), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0), + Pair.of(IN_SERVICE, 0), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0)); + + List<ContainerReplicaOp> pending = new ArrayList<>(); + pending.add(ContainerReplicaOp.create( + DELETE, MockDatanodeDetails.randomDatanodeDetails(), 0)); + pending.add(ContainerReplicaOp.create( + DELETE, MockDatanodeDetails.randomDatanodeDetails(), 0)); + + requestBuilder.setContainerReplicas(replicas) + .setPendingOps(pending) + .setContainerInfo(container); + OverReplicatedHealthResult result = (OverReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.OVER_REPLICATED, result.getHealthState()); + Assert.assertEquals(4, result.getExcessRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(1, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.OVER_REPLICATED)); + } + + @Test + public void testOverReplicatedContainerFixedByPending() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = createReplicas(container.containerID(), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0)); + + List<ContainerReplicaOp> pending = new ArrayList<>(); + pending.add(ContainerReplicaOp.create( + DELETE, MockDatanodeDetails.randomDatanodeDetails(), 0)); + + requestBuilder.setContainerReplicas(replicas) + .setPendingOps(pending) + .setContainerInfo(container); + OverReplicatedHealthResult result = (OverReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.OVER_REPLICATED, result.getHealthState()); + Assert.assertEquals(1, result.getExcessRedundancy()); + Assert.assertTrue(result.isSufficientlyReplicatedAfterPending()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + // Fixed by pending so nothing queued. + Assert.assertEquals(0, repQueue.overReplicatedQueueSize()); + // Still over replicated, so the report should contain it + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.OVER_REPLICATED)); + } + + @Test + public void testOverReplicatedContainerWithMaintenance() { + ContainerInfo container = createContainerInfo(repConfig); + Set<ContainerReplica> replicas = createReplicas(container.containerID(), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0), + Pair.of(IN_SERVICE, 0), Pair.of(IN_SERVICE, 0), + Pair.of(IN_MAINTENANCE, 0), Pair.of(DECOMMISSIONED, 0)); + + requestBuilder.setContainerReplicas(replicas) + .setContainerInfo(container); + OverReplicatedHealthResult result = (OverReplicatedHealthResult) + healthCheck.checkHealth(requestBuilder.build()); + Assert.assertEquals(HealthState.OVER_REPLICATED, result.getHealthState()); + Assert.assertEquals(1, result.getExcessRedundancy()); + Assert.assertFalse(result.isSufficientlyReplicatedAfterPending()); + + Assert.assertTrue(healthCheck.handle(requestBuilder.build())); + Assert.assertEquals(0, repQueue.underReplicatedQueueSize()); + Assert.assertEquals(1, repQueue.overReplicatedQueueSize()); + Assert.assertEquals(1, report.getStat( + ReplicationManagerReport.HealthState.OVER_REPLICATED)); + } + + @Test + public void testOverReplicatedContainerDueToMaintenance() { Review Comment: Since we're testing the HEALTHY case, let's change the test's name? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
