ayushtkn commented on code in PR #3843:
URL: https://github.com/apache/ozone/pull/3843#discussion_r996825221
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -75,8 +75,10 @@ public class DatanodeConfiguration {
static final boolean CONTAINER_SCHEMA_V3_ENABLED_DEFAULT = false;
static final long ROCKSDB_LOG_MAX_FILE_SIZE_BYTES_DEFAULT = 32 * 1024 * 1024;
static final int ROCKSDB_LOG_MAX_FILE_NUM_DEFAULT = 64;
+ // one hour
static final long ROCKSDB_DELETE_OBSOLETE_FILES_PERIOD_MICRO_SECONDS_DEFAULT
=
- 6 * 60 * 60 * 1000 * 1000;
+ 1 * 60 * 60 * 1000 * 1000;
+ static final int ROCKSDB_MAX_OPEN_FILES_DEFAULT = 1024;
Review Comment:
Is this working? looks like a numeric overflow case to me, Integer
multiplication is being implicitly cast to long.
Tried a small assertion
```
assertEquals(1L * 60 * 60 * 1000 * 1000,
ROCKSDB_DELETE_OBSOLETE_FILES_PERIOD_MICRO_SECONDS_DEFAULT);
```
It indeed gives me a ``-694967296``
Secondly why are we changing the default value in the scope of adding a new
property?
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -338,16 +340,24 @@ public void setWaitOnAllFollowers(boolean val) {
)
private int rocksdbMaxFileNum = ROCKSDB_LOG_MAX_FILE_NUM_DEFAULT;
- @Config(key = "rocksdb.delete_obsolete_files_period",
- defaultValue = "6h", timeUnit = MICROSECONDS,
+ @Config(key = "rocksdb.delete-obsolete-files-period",
Review Comment:
Are we changing the config name? replacing `_` with `-`, Even above
``ROCKSDB_DELETE_OBSOLETE_FILES_PERIOD_MICRO_SECONDS_KEY`` has ``_``, I am not
sure but changing config names must be an incompatible change right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
