ChenSammi commented on code in PR #3843:
URL: https://github.com/apache/ozone/pull/3843#discussion_r997667304


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -338,16 +340,24 @@ public void setWaitOnAllFollowers(boolean val) {
   )
   private int rocksdbMaxFileNum = ROCKSDB_LOG_MAX_FILE_NUM_DEFAULT;
 
-  @Config(key = "rocksdb.delete_obsolete_files_period",
-      defaultValue = "6h", timeUnit = MICROSECONDS,
+  @Config(key = "rocksdb.delete-obsolete-files-period",

Review Comment:
   The main purpose of Replacing _ with - is to be consistent with other 
rocksdb property name style. The property is recently added, should not 
introduce any compatibility issue. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to