errose28 commented on code in PR #3841:
URL: https://github.com/apache/ozone/pull/3841#discussion_r1001073471
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/upgrade/TestDatanodeUpgradeToScmHA.java:
##########
@@ -103,6 +104,8 @@ public TestDatanodeUpgradeToScmHA(boolean
scmHAAlreadyEnabled) {
this.scmHAAlreadyEnabled = scmHAAlreadyEnabled;
conf = new OzoneConfiguration();
conf.setBoolean(ScmConfigKeys.OZONE_SCM_HA_ENABLE_KEY,
scmHAAlreadyEnabled);
+ // DATANODE_SCHEMA_V3 has higher feature version than SCM_HA
+ conf.setBoolean(DatanodeConfiguration.CONTAINER_SCHEMA_V3_ENABLED, false);
Review Comment:
This still sounds like a bug though right? It is valid for a user to have
ozone 1.1.0 (first layout version) and upgrade to Ozone 1.3.0 (schema v3) and
turn on the schema v3 config when they do the upgrade. Schema v3 should still
be disabled until the DN is finalized. When the DN finalizes, the rocksDB
should be created and then schema v3 should work for all new containers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
