ChenSammi commented on code in PR #3841:
URL: https://github.com/apache/ozone/pull/3841#discussion_r1002845044
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/upgrade/TestDatanodeUpgradeToScmHA.java:
##########
@@ -103,6 +104,8 @@ public TestDatanodeUpgradeToScmHA(boolean
scmHAAlreadyEnabled) {
this.scmHAAlreadyEnabled = scmHAAlreadyEnabled;
conf = new OzoneConfiguration();
conf.setBoolean(ScmConfigKeys.OZONE_SCM_HA_ENABLE_KEY,
scmHAAlreadyEnabled);
+ // DATANODE_SCHEMA_V3 has higher feature version than SCM_HA
+ conf.setBoolean(DatanodeConfiguration.CONTAINER_SCHEMA_V3_ENABLED, false);
Review Comment:
@errose28, the flow you described is correct and works. The key point is
rocksDB is created during upgrade from 1.1.0 to 1.3.0 (1.2.1 in the middle)
when Schema V3 finalization action is executed.
But in this test, it only upgrades like from 1.0.0 to 1.1.0, only the
SCM-HA related finalization action is executed, using cluster ID instead of scm
ID as the data root directory. Schema V3 finalization action will not
executed, there is no change to create rocksDB for every volume. In this case,
if Schema V3 is enabled, then you can image what will happen. Not sure if I
explain the difference clearly enough now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
