sokui commented on code in PR #3835:
URL: https://github.com/apache/ozone/pull/3835#discussion_r1003967992
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:
##########
@@ -373,6 +375,8 @@ public RegisteredCommand register(
String dnsName;
String networkLocation;
+ String ipAddress = datanodeDetails.getIpAddress();
+ String hostName = datanodeDetails.getHostName();
Review Comment:
Please also be very careful. In my impression, in some of my test,
datanodeDetails.getHostName() might give you IP instead of host name. Please
test if your approach does not have bugs for this case as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
