kerneltime commented on code in PR #3835:
URL: https://github.com/apache/ozone/pull/3835#discussion_r1013714193
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/RatisHelper.java:
##########
@@ -101,18 +98,16 @@ public static UUID toDatanodeId(RaftProtos.RaftPeerProto
peerId) {
}
private static String toRaftPeerAddress(DatanodeDetails id, Port.Name port) {
- if (datanodeUseHostName()) {
- final String address =
- id.getHostName() + ":" + id.getPort(port).getValue();
+ final String address;
+ if (Strings.isNullOrEmpty(id.getIpAddress())) {
Review Comment:
We are changing the behavior of this call. Using hostnames if provided
should be the preferred way to evaluate the address, not sure why IP address is
preferred here (if both are available)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
