duongkame commented on PR #3878: URL: https://github.com/apache/ozone/pull/3878#issuecomment-1302813143
Thanks @xBis7 for the patch. > The name is in the format Caller(username).MetricType eg. Caller(hadoop).Volume. The username might exist in the metric name for a purpose. We don't want to change the way the metric works but the way it's presented. The cleanest way to deal with this seems to filter the metric in PrometheusMetricsSink. I still think this should rather be a change in `hadoop-common`. To keep it backward compatible, we may just introduce a new monitorable metric without changing the existing one. Capturing and modifying metrics in Ozone `PrometheusMetricsSink` looks pretty hacky, but if we have to do so, we'd rather copy the metrics to a new one without changing the original metric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
