kaijchen commented on code in PR #3923:
URL: https://github.com/apache/ozone/pull/3923#discussion_r1018868397
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestBlockDeletingService.java:
##########
@@ -503,18 +509,21 @@ public void testBlockDeletion() throws Exception {
@Test
public void testWithUnrecordedBlocks() throws Exception {
// Skip schemaV1, when markBlocksForDeletionSchemaV1, the unrecorded blocks
- // from received TNXs will be skipped to delete and will not be added into
- // the NumPendingDeletionBlocks
+ // from received TNXs will be deleted, not in BlockDeletingService
if (Objects.equals(schemaVersion, SCHEMA_V1)) {
Review Comment:
This if statement can be replaced by
`Assume.assumeFalse(Objects.equals(schemaVersion, SCHEMA_V1))`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
