Xushaohong commented on code in PR #3923:
URL: https://github.com/apache/ozone/pull/3923#discussion_r1018998012
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestBlockDeletingService.java:
##########
@@ -306,7 +311,8 @@ private void putChunksInBlock(int numOfChunksPerBlock, int
i,
long chunkLength = 100;
try {
for (int k = 0; k < numOfChunksPerBlock; k++) {
- final String chunkName = String.format("block.%d.chunk.%d", i, k);
+ final String chunkName = String.format("%d_chunk_%d_block_%d",
Review Comment:
Both of the chunk name works fine with the parameterized test, the old
chunk name format is not working in the real cluster, no need to keep it.
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestBlockDeletingService.java:
##########
@@ -306,7 +311,8 @@ private void putChunksInBlock(int numOfChunksPerBlock, int
i,
long chunkLength = 100;
try {
for (int k = 0; k < numOfChunksPerBlock; k++) {
- final String chunkName = String.format("block.%d.chunk.%d", i, k);
+ final String chunkName = String.format("%d_chunk_%d_block_%d",
Review Comment:
Both of the chunk names work fine with the parameterized test, the old
chunk name format is not working in the real cluster, no need to keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
