jojochuang commented on code in PR #3810:
URL: https://github.com/apache/ozone/pull/3810#discussion_r1019492094
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##########
@@ -1157,19 +1175,19 @@ public ConfigurationSource getConfSource() {
*/
private abstract class OzoneListingIterator {
private final Path path;
- private final FileStatus status;
+ private final FileStatusAdapter status;
private String pathKey;
private Iterator<BasicKeyInfo> keyIterator = null;
private boolean isFSO;
OzoneListingIterator(Path path, boolean isFSO)
throws IOException {
this.path = path;
- this.status = getFileStatus(path);
+ this.status = getFileStatusAdapter(path);
this.pathKey = pathToKey(path);
this.isFSO = isFSO;
if (!isFSO) {
- if (status.isDirectory()) {
+ if (status.isDir()) {
Review Comment:
ditto
##########
hadoop-ozone/dist/src/main/compose/ozonesecure/test.sh:
##########
@@ -27,7 +27,7 @@ export SECURITY_ENABLED=true
: ${OZONE_BUCKET_KEY_NAME:=key1}
-start_docker_env
+start_docker_env 5
Review Comment:
Is this change required? Just curious
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##########
@@ -450,7 +451,7 @@ private class DeleteIterator extends OzoneListingIterator {
throws IOException {
super(f);
this.recursive = recursive;
- if (getStatus().isDirectory()
+ if (getStatus().isDir()
Review Comment:
Isn't this a deprecated API and which is the same as isDirectory()?
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##########
@@ -1210,15 +1228,15 @@ boolean iterate() throws IOException {
List<String> keyPathList = new ArrayList<>();
int batchSize = getConf().getInt(OZONE_FS_ITERATE_BATCH_SIZE,
OZONE_FS_ITERATE_BATCH_SIZE_DEFAULT);
- if (status.isDirectory()) {
+ if (status.isDir()) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
