jojochuang commented on code in PR #3810:
URL: https://github.com/apache/ozone/pull/3810#discussion_r1022177934
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/FileStatusAdapter.java:
##########
@@ -131,4 +142,27 @@ public BlockLocation[] getBlockLocations() {
return blockLocations;
}
+ @Override
+ public String toString() {
+ StringBuilder sb = new StringBuilder();
+ sb.append(getClass().getSimpleName())
+ .append("{")
+ .append("path=" + path)
+ .append("; isDirectory=" + isdir);
+ if (isFile()) {
+ sb.append("; length=" + length)
+ .append("; diskConsumed= " + getDiskConsumed())
+ .append("; blockReplication=" + blockReplication)
+ .append("; blocksize=" + blocksize);
+ }
+ sb.append("; accessTime=" + accessTime)
+ .append("; owner=" + owner)
+ .append("; group=" + group)
+ .append("; permission=" + permission)
+ .append("; isSymlink=" + getSymlink())
+ .append("}");
Review Comment:
IMO better to rewrite by calling more append rather than string
concatenation.
e.g.
```suggestion
.append("path=").append(path)
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
