neils-dev commented on code in PR #3948:
URL: https://github.com/apache/ozone/pull/3948#discussion_r1019696973
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/x509/SecurityConfig.java:
##########
@@ -123,10 +122,8 @@ public SecurityConfig(ConfigurationSource configuration) {
// Please Note: To make it easy for our customers we will attempt to read
// HDDS metadata dir and if that is not set, we will use Ozone directory.
- // TODO: We might want to fix this later.
- this.metadatDir = this.configuration.get(HDDS_METADATA_DIR_NAME,
- configuration.get(OZONE_METADATA_DIRS,
- configuration.get(HDDS_DATANODE_DIR_KEY)));
+ this.metadataDir = this.configuration.get(HDDS_METADATA_DIR_NAME,
+ configuration.get(OZONE_METADATA_DIRS));
Review Comment:
We can add a null check here, to log the error where it originates, for the
`metadataDir `should both the `hdds.metadata.dir` ozone-site property and the
fallback `ozone.metadata.dirs `is not set, such as
https://github.com/apache/ozone/blob/fe748d6776fc33124dad2d6cfc5f5dceee038a7f/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/hdds/datanode/metadata/CRLDBDefinition.java#L77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
