errose28 commented on PR #3948: URL: https://github.com/apache/ozone/pull/3948#issuecomment-1314620934
Here is my understanding, not sure if this is totally right: On the datanode, this change is safe and desirable. The datanode will fail to start if ozone.metadata.dirs is not specified, so hdds.datanode.dir never gets used. We would never want cert info on hdds.datanode.dir anyways since this is specified multiple times for each datanode volume. The instance that gets used is somewhat non-deterministic and if that volume fails the cert info will be gone. On other components, I am not sure. If the cert directory they try to use is empty, will they get new ones from SCM? It seems like there should be a way for components to specify their preferred storage directory. Then for compatibility inside the SecurityConfig, we can use existing defaults if that is not set. However, this would cause the cert directory to change on upgrade if the priority of existing configs was changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
