swamirishi commented on code in PR #3956:
URL: https://github.com/apache/ozone/pull/3956#discussion_r1021823595
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationQueue.java:
##########
@@ -62,6 +70,11 @@ public void
enqueue(ContainerHealthResult.OverReplicatedHealthResult
return overRepQueue.poll();
}
+ public ContainerHealthResult.MisReplicatedHealthResult
+ dequeueMisReplicatedContainer() {
Review Comment:
Currently this PR does not have any handler calling this function right? Do
we need to have dummy handler in this PR before it which calls this function so
that this queue doesn't fill up.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/ECReplicationCheckHandler.java:
##########
@@ -82,10 +91,20 @@ public boolean handle(ContainerCheckRequest request) {
ReplicationManagerReport.HealthState.OVER_REPLICATED, containerID);
ContainerHealthResult.OverReplicatedHealthResult overHealth
= ((ContainerHealthResult.OverReplicatedHealthResult) health);
- if (!overHealth.isSufficientlyReplicatedAfterPending()) {
+ if (!overHealth.isReplicatedOkAfterPending()) {
request.getReplicationQueue().enqueue(overHealth);
}
return true;
+ } else if (health.getHealthState() ==
Review Comment:
nit: Should we change this if else ladder to switch case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
