sodonnel commented on code in PR #3956:
URL: https://github.com/apache/ozone/pull/3956#discussion_r1021856229
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/ECReplicationCheckHandler.java:
##########
@@ -82,10 +91,20 @@ public boolean handle(ContainerCheckRequest request) {
ReplicationManagerReport.HealthState.OVER_REPLICATED, containerID);
ContainerHealthResult.OverReplicatedHealthResult overHealth
= ((ContainerHealthResult.OverReplicatedHealthResult) health);
- if (!overHealth.isSufficientlyReplicatedAfterPending()) {
+ if (!overHealth.isReplicatedOkAfterPending()) {
request.getReplicationQueue().enqueue(overHealth);
}
return true;
+ } else if (health.getHealthState() ==
Review Comment:
With 3 states, I think it is fine as it is for now. If we started getting
more states we can change it. I personally don't see a great benefit with the
switch statement over the `if` calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
