sodonnel commented on code in PR #3963:
URL: https://github.com/apache/ozone/pull/3963#discussion_r1029178861
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ContainerReplicaPendingOps.java:
##########
@@ -261,6 +259,16 @@ private boolean
completeOp(ContainerReplicaOp.PendingOpType opType,
return found;
}
+ public void registerOpCompletionHandler(
Review Comment:
Could we create a new Jira for these changes to ContainerReplicaPendingOps
so it is a self contained change and not mixed into this larger one? We also
need a couple of simple tests (or changes to existing tests) to ensure the
handler is called in both scenarios.
It is so much easier to review a series of smaller Jira that a large one
like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
