adoroszlai commented on code in PR #3997:
URL: https://github.com/apache/ozone/pull/3997#discussion_r1031207707
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -668,13 +669,20 @@ public void createBucket(
builder.setDefaultReplicationConfig(defaultReplicationConfig);
}
+ ReplicationType replicationType = defaultReplicationConfig == null ?
+ ReplicationType.RATIS : defaultReplicationConfig.getType();
Review Comment:
I don't think the client should make assumptions about default replication
on the server. If the client does not set the bucket's default replication
config, it should omit `Replication Type set to ...` from the message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
