adoroszlai commented on code in PR #3997:
URL: https://github.com/apache/ozone/pull/3997#discussion_r1032993486
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -668,13 +668,21 @@ public void createBucket(
builder.setDefaultReplicationConfig(defaultReplicationConfig);
}
+ String replicationType = defaultReplicationConfig == null
+ ? "with server-side default replication type"
+ : defaultReplicationConfig.getType().toString();
+
String layoutMsg = bucketLayout != null
? "with bucket layout " + bucketLayout
: "with server-side default bucket layout";
LOG.info("Creating Bucket: {}/{}, {}, {} as owner, Versioning {}, " +
- "Storage Type set to {} and Encryption set to {} ",
+ "Storage Type set to {} and Encryption set to {}, " +
+ "Replication Type set to {}, Namespace Quota set to {}, " +
Review Comment:
Can you please tweak the replication-related part a bit?
1. `Replication Type set to with server-side default replication type`
sounds awkward.
2. I think it should include not only replication type, but all details of
the replication config, available via `configFormat()` of `ReplicationConfig`.
But I just realized `DefaultReplicationConfig` does not easily provide those
details, so I created a PR (#4005) to expose them. If that's merged, we can
make the message more helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
