hemantk-12 commented on code in PR #3993:
URL: https://github.com/apache/ozone/pull/3993#discussion_r1034094816
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOmMetadataManager.java:
##########
@@ -689,12 +690,17 @@ public void testListSnapshot() throws Exception {
}
//Test listing snapshots with no volume name.
- Assert.assertThrows(OMException.class, () ->
omMetadataManager.listSnapshot(
- null, null));
+ Assert.assertThrows(OMException.class,
Review Comment:
It would be great if you separate out success and failure scenarios. Also
use [parameterized test](https://www.baeldung.com/parameterized-tests-junit-5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
