chungen0126 commented on code in PR #3993:
URL: https://github.com/apache/ozone/pull/3993#discussion_r1035586612
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOmMetadataManager.java:
##########
@@ -689,12 +690,17 @@ public void testListSnapshot() throws Exception {
}
//Test listing snapshots with no volume name.
- Assert.assertThrows(OMException.class, () ->
omMetadataManager.listSnapshot(
- null, null));
+ Assert.assertThrows(OMException.class,
Review Comment:
In junit4, if we want to write a parameterized test in
`TestOmMetadataManager`, we must use `@RunWith(Enclosed.class)`.
It might change the whole class. I'm not sure if it is necessary or there is
other way to do it.
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOmMetadataManager.java:
##########
@@ -689,12 +690,17 @@ public void testListSnapshot() throws Exception {
}
//Test listing snapshots with no volume name.
- Assert.assertThrows(OMException.class, () ->
omMetadataManager.listSnapshot(
- null, null));
+ Assert.assertThrows(OMException.class,
+ () -> omMetadataManager.listSnapshot(null, null));
//Test listing snapshots with no bucket name.
- Assert.assertThrows(OMException.class, () ->
omMetadataManager.listSnapshot(
- vol1, null));
+ Assert.assertThrows(OMException.class,
+ () -> omMetadataManager.listSnapshot(vol1, null));
+
+ //Test listing snapshots with non-existent bucket.
+
+ Assert.assertThrows(OMException.class,
+ () -> omMetadataManager.listSnapshot(vol1, nonexistentBucket));
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
