GeorgeJahad commented on code in PR #3981:
URL: https://github.com/apache/ozone/pull/3981#discussion_r1036509251
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -711,24 +703,28 @@ public synchronized List<String> getSSTDiffList(
/**
* Core getSSTDiffList logic.
Review Comment:
```suggestion
* Core getSSTDiffList logic.
* For each sst in the src snapshot, traverse the dag to find its final
* successors. If any of those successors match an sst in the dest
* snapshot, add it to the sameFiles map; (it doesn't need further
* diffing). Otherwise, add it to the differentFiles map, as it will
* need further diffing.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
