smengcl commented on code in PR #3981:
URL: https://github.com/apache/ozone/pull/3981#discussion_r1040055115
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java:
##########
@@ -298,6 +308,18 @@ private ManagedColumnFamilyOptions getDefaultCfOptions() {
.orElseGet(defaultCfProfile::getColumnFamilyOptions);
}
+ /**
+ * Get default column family options, but with column family write buffer
+ * size limit overridden.
+ * @param writeBufferSize Specify column family write buffer size.
+ * @return ManagedColumnFamilyOptions
+ */
+ private ManagedColumnFamilyOptions getDefaultCfOptions(long writeBufferSize)
{
Review Comment:
I'd prefer delaying any further refactoring of a shared class like
`DBStoreBuilder` until we merge to master to prevent headaches around merge
conflicts. Would you like to file a jira for this so we can fix this after the
merge?
It is still the "default" in the sense that we are still getting all the
other default CF options. Just with write buffer size explicitly overridden, as
mentioned in the javadoc. Similar to `getDefaultDBOptions(tableConfigs)` right
below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
