sodonnel commented on code in PR #4013:
URL: https://github.com/apache/ozone/pull/4013#discussion_r1038600565
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketArgs.java:
##########
@@ -343,9 +357,10 @@ public static OmBucketArgs getFromProtobuf(BucketArgs
bucketArgs) {
bucketArgs.getOwnerName() : null);
// OmBucketArgs ctor already has more arguments, so setting the default
// replication config separately.
- omBucketArgs.setDefaultReplicationConfig(
- new
DefaultReplicationConfig(bucketArgs.getDefaultReplicationConfig()));
-
+ if (bucketArgs.hasDefaultReplicationConfig()) {
Review Comment:
I think you can fix this issue with just this `if` statement added here, but
I am not 100% certain. It kind of depends if we need a way to remove a default
rep config from a bucket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
