smengcl commented on code in PR #4045:
URL: https://github.com/apache/ozone/pull/4045#discussion_r1049032605


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -151,7 +151,9 @@ public static DBCheckpoint createOmSnapshotCheckpoint(
     // Write snapshot generation (latest sequence number) to compaction log.
     // This will be used for DAG reconstruction as snapshotGeneration.
     dbCpDiffer.appendSequenceNumberToCompactionLog(dbLatestSequenceNumber,

Review Comment:
   We can rename this method (and the comment above) now that it does more than 
just appending sequence number. Like `appendSnapshotCreationToCompactionLog`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to