GeorgeJahad commented on code in PR #4045:
URL: https://github.com/apache/ozone/pull/4045#discussion_r1049079488
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -174,6 +198,14 @@ public RocksDBCheckpointDiffer(String metadataDir, String
sstBackupDir,
// Active DB location is used in getSSTFileSummary
this.activeDBLocationStr = activeDBLocation.toString() + "/";
+
+ this.maxAllowedTimeInDag = maxTimeAllowedForSnapshotInDagInMs;
+ this.executor = Executors.newSingleThreadScheduledExecutor();
+ this.executor.scheduleWithFixedDelay(
+ this::pruneOlderSnapshotsWithCompactionHistory,
+ 0,
+ pruneCompactionDagDaemonRunIntervalInMs,
+ TimeUnit.MILLISECONDS);
Review Comment:
This PR doesn't seem to include "compaction log pruning and SST file
pruning". Is that correct? Is that supposed to happen in a different PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
