xBis7 commented on code in PR #4094: URL: https://github.com/apache/ozone/pull/4094#discussion_r1050716668
########## hadoop-hdds/framework/pom.xml: ########## @@ -29,7 +29,16 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> <name>Apache Ozone HDDS Server Framework</name> <packaging>jar</packaging> + <properties> + <ozone-common.version>1.3.0-SNAPSHOT</ozone-common.version> + </properties> + <dependencies> + <dependency> + <groupId>org.apache.ozone</groupId> + <artifactId>ozone-common</artifactId> + <version>${ozone-common.version}</version> + </dependency> Review Comment: @adoroszlai Thanks for looking into this. I don't think there is a package where we can access both `OMConfigKeys` and `ScmConfigKeys` but we might be able to simplify the switch case that requires both of them. We have prometheus metrics only for SCM and OM. We can only check the `ScmConfigKeys` and if it doesn't match then we can assume the server is OM without checking `OMConfigKeys`. This might not be the best approach. We have the hostname available. There might be a way to use that to get the server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
