adoroszlai commented on code in PR #4094: URL: https://github.com/apache/ozone/pull/4094#discussion_r1050914267
########## hadoop-hdds/framework/pom.xml: ########## @@ -29,7 +29,16 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> <name>Apache Ozone HDDS Server Framework</name> <packaging>jar</packaging> + <properties> + <ozone-common.version>1.3.0-SNAPSHOT</ozone-common.version> + </properties> + <dependencies> + <dependency> + <groupId>org.apache.ozone</groupId> + <artifactId>ozone-common</artifactId> + <version>${ozone-common.version}</version> + </dependency> Review Comment: I think there's a simple, more generic solution: `PrometheusMetricsSink` is created in `BaseHttpServer`, which has service-specific subclasses. So define an method in `BaseHttpServer` that returns the info you want to pass to `PrometheusMetricsSink`, then override in `OzoneManagerHttpServer`, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
