errose28 commented on PR #3920:
URL: https://github.com/apache/ozone/pull/3920#issuecomment-1358852371
Thanks for the detailed review @siddhantsangwan. I finished all previously
WIP tests and they are covering more cases around closing containers with
unhealthy replicas and saving BCSIDs like you mentioned.
> A side effect of this change is that Containers such as {Container State:
CLOSED, Replicas: CLOSED, CLOSING, CLOSING} would be called under replicated. I
saw that the handler will try to replicate only if closing these replicas won't
achieve sufficient replication. Do you think it can be confusing to call such a
container under replicated?
Yes even though the code is doing the right thing by trying to close them,
we should probably not report these as under replicated. I will fix the report
during my day tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
